deniskuzZ commented on code in PR #6259:
URL: https://github.com/apache/hive/pull/6259#discussion_r2701571318
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java:
##########
@@ -2075,11 +2075,31 @@ public boolean
isPartitioned(org.apache.hadoop.hive.ql.metadata.Table hmsTable)
return table.spec().isPartitioned();
}
+ private boolean isPartitionPresent(org.apache.hadoop.hive.ql.metadata.Table
table,
+ Map<String, String> partitionSpec) throws
SemanticException {
+ try {
+ List<String> partNames = getPartitionNames(table, partitionSpec);
Review Comment:
i don't think that is ok, since it's allowed to compact on partition that is
not part of current spec (after partition evolution)
same applies to describe
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
