ramitg254 commented on code in PR #6259:
URL: https://github.com/apache/hive/pull/6259#discussion_r2715540726
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java:
##########
@@ -1345,7 +1348,14 @@ public TableSpec(Hive db, HiveConf conf, ASTNode ast,
boolean allowDynamicPartit
if (partHandle == null) {
// if partSpec doesn't exists in DB, return a delegate one
// and the actual partition is created in MoveTask
- partHandle = new Partition(tableHandle, partSpec, null);
+ try {
+ partHandle = tableHandle.hasNonNativePartitionSupport() ?
+ new DummyPartition(tableHandle,
Warehouse.makePartName(partSpec, false), partSpec) :
Review Comment:
I think we shouldn't think for transform scenario here as before the api was
updated:
it was just returning dummy partition for given spec
and after the updation of api as well if we partition is found then dummy
partition is returned by api itself otherwise it gets returned via this piece
of code.
both these before and after scenarios are independent of transform so
Just trying to keep old behaviour intact so that no new ambiguity should
occur.
Will extract into separate method `getPartitionHandle`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
