thomasrebele commented on code in PR #6274:
URL: https://github.com/apache/hive/pull/6274#discussion_r2717138741
##########
ql/src/java/org/apache/hadoop/hive/ql/io/parquet/write/DataWritableWriter.java:
##########
@@ -157,7 +159,8 @@ private DataWriter createWriter(ObjectInspector inspector,
Type type) {
case TIMESTAMP:
return new TimestampDataWriter((TimestampObjectInspector)inspector);
case DECIMAL:
- return new DecimalDataWriter((HiveDecimalObjectInspector)inspector);
+ return new DecimalDataWriter((HiveDecimalObjectInspector) inspector,
Review Comment:
At first I thought the space after the cast was incorrectly formatted. Then
I looked into the [Coding
conventions](https://hive.apache.org/community/resources/howtocontribute/#coding-conventions)
which redirect to [Sun's
conventions](https://web.archive.org/web/20140228225807/http://www.oracle.com/technetwork/java/codeconventions-150003.pdf),
and section 8.2 says "Casts should be followed by a blank". So the space needs
to be there.
##########
ql/src/test/queries/clientpositive/parquet_join_dec_col_diff_pre_scale.q:
##########
@@ -0,0 +1,21 @@
+CREATE TABLE table_a (col_dec_a decimal(12,7));
+CREATE TABLE table_b(col_dec_b decimal(15,5));
Review Comment:
Nit: would be better to use consistent spacing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
