deniskuzZ commented on code in PR #6259:
URL: https://github.com/apache/hive/pull/6259#discussion_r2719672718
##########
ql/src/java/org/apache/hadoop/hive/ql/metadata/DummyPartition.java:
##########
@@ -80,8 +81,12 @@ public LinkedHashMap<String, String> getSpec() {
@Override
public List<String> getValues() {
+ Table table = this.getTable();
List<String> values = new ArrayList<String>();
- for (FieldSchema fs : this.getTable().getPartCols()) {
+ for (FieldSchema fs :
Review Comment:
why do we need
```
List<FieldSchema> partitionColumns = null;
if (table.isPartitioned()) {
partitionColumns = table.hasNonNativePartitionSupport() ?
table.getStorageHandler().getPartitionKeys(table) :
table.getPartCols();
}
```
can we pass partition arg here and reuse?
this is mess, full of code duplication, why not pass `Partition partition`
to `addPartitionData(out, conf, columnPath, table, isFormatted,
isOutputPadded);` - doesn't make any sence
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
