deniskuzZ commented on code in PR #6259:
URL: https://github.com/apache/hive/pull/6259#discussion_r2719902399
##########
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/info/desc/DescTableAnalyzer.java:
##########
@@ -102,7 +103,7 @@ public void analyzeInternal(ASTNode root) throws
SemanticException {
inputs.add(new ReadEntity(table));
- DescTableDesc desc = new DescTableDesc(ctx.getResFile(), tableName,
partitionSpec, columnPath, isExt, isFormatted);
+ DescTableDesc desc = new DescTableDesc(ctx.getResFile(), tableName,
partitionSpec, partition, columnPath, isExt, isFormatted);
Review Comment:
do we need partitionSpec after we pass partition?
##########
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/info/desc/DescTableAnalyzer.java:
##########
@@ -102,7 +103,7 @@ public void analyzeInternal(ASTNode root) throws
SemanticException {
inputs.add(new ReadEntity(table));
- DescTableDesc desc = new DescTableDesc(ctx.getResFile(), tableName,
partitionSpec, columnPath, isExt, isFormatted);
+ DescTableDesc desc = new DescTableDesc(ctx.getResFile(), tableName,
partitionSpec, partition, columnPath, isExt, isFormatted);
Review Comment:
do we still need partitionSpec after we pass partition?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
