humashankar26 opened a new pull request, #6302: URL: https://github.com/apache/hive/pull/6302
What changes were proposed in this pull request? I have upgraded the logging infrastructure from the SLF4J 1.7.x line to the modern 2.0.13 version. To ensure this didn't break Hive's complex logging and metrics reporting, I performed a full "bridge and provider" realignment across the following key areas: Version Force: Updated slf4j-api to 2.0.13 in the root pom.xml, standalone-metastore/pom.xml, and storage-api/pom.xml. Provider Migration: Swapped the old slf4j-reload4j (1.7.36) for version 2.0.13 to support the Java ServiceLoader mechanism required by SLF4J 2.x. Bridge Realignment: Updated jcl-over-slf4j to 2.0.13 and introduced log4j-slf4j2-impl (v2.24.3) in the root and service modules. This was necessary to allow Hive's Log4j2-based metrics and timing systems to communicate with the new SLF4J 2.0 API. Why are the changes needed? This upgrade is critical for two reasons: Security: It moves Hive away from the aging 1.7.x line, resolving several security scanner flags and moving toward the more secure ServiceLoader/SPI architecture. Reliability: It fixes a series of "silent" failures where metrics and timing events were being dropped because SLF4J 2.0 couldn't find a valid 1.7.x binder. This ensures that Atlas, Ranger, and internal Metastore timers report data accurately. Does this PR introduce any user-facing change? No. This is a backend architectural update. Logging behavior remains identical for the end-user, though developers will benefit from the more stable 2.0 SPI under the hood. How was this patch tested? I conducted an extensive multi-stage testing process to ensure no regressions: Dependency Tree Audit: Verified via mvn dependency:tree that all 56 modules have converged on version 2.0.13 and that no "zombie" 1.7.x bindings remain. Fixing Metric Regressions: Resolved failures in TestAtlasLoadTask, TestRangerDumpTask, and TestMetrics where metrics were returning 0 due to NOP-logger defaults. Timing & Operations: Verified TestHiveRemote and TestOperationLogManager to ensure that query-specific logs and API timing strings are correctly captured. Local Build: Ran a full mvn clean install -DskipTests to confirm that all modules (especially ql and service) compile correctly with the new SLF4J 2.x bridges. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
