konstantinb commented on code in PR #6244:
URL: https://github.com/apache/hive/pull/6244#discussion_r2776483842


##########
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFCoalesce.java:
##########
@@ -45,13 +48,16 @@
 public class GenericUDFCoalesce extends GenericUDF implements 
StatEstimatorProvider {

Review Comment:
   I agree that the update to CASE/WHEN/IF do not directly apply to 
COACECENSCE. applying a specific fix to return MAX(NDV(col1), ... NDV(colN)) + 
(1 if there's a trailing constant)



##########
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFCoalesce.java:
##########
@@ -45,13 +48,16 @@
 public class GenericUDFCoalesce extends GenericUDF implements 
StatEstimatorProvider {

Review Comment:
   I agree that the updates to CASE/WHEN/IF do not directly apply to 
COACECENSCE. applying a specific fix to return MAX(NDV(col1), ... NDV(colN)) + 
(1 if there's a trailing constant)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to