okumin opened a new pull request, #6305:
URL: https://github.com/apache/hive/pull/6305
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
https://cwiki.apache.org/confluence/display/Hive/HowToContribute
2. Ensure that you have created an issue on the Hive project JIRA:
https://issues.apache.org/jira/projects/HIVE/summary
3. Ensure you have added or run the appropriate tests for your PR:
4. If the PR is unfinished, add '[WIP]' in your PR title, e.g.,
'[WIP]HIVE-XXXXX: Your PR title ...'.
5. Be sure to keep the PR description updated to reflect all changes.
6. Please write your PR title to summarize what this PR proposes.
7. If possible, provide a concise example to reproduce the issue for a
faster review.
-->
### What changes were proposed in this pull request?
Remove dynamic instantiation based on the Hive version. Most likely, the
conditional instantiation was implemented when the related logic existed in
Apache Iceberg, aiming to be effective for both Hive 2 and 3 with a single
source code base. This is an example of Iceberg 1.3.0.
https://github.com/apache/iceberg/blob/apache-iceberg-1.3.0/mr/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergInputFormat.java
### Why are the changes needed?
I think the reflections are no longer needed, and having them makes
development a bit hard; e.g., code jumps are disabled.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Unit and integration test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
