okumin commented on code in PR #6270: URL: https://github.com/apache/hive/pull/6270#discussion_r2778378238
########## standalone-metastore/metastore-rest-catalog/src/main/java/org/apache/iceberg/rest/standalone/StandaloneRESTCatalogServer.java: ########## @@ -0,0 +1,210 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 Review Comment: Please use [asf.header](https://github.com/apache/hive/blob/master/checkstyle/asf.header) at this point. I locally have a follow-up patch of HIVE-29245, but it's not complete. https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=6270&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true ########## standalone-metastore/metastore-rest-catalog/src/main/java/org/apache/iceberg/rest/HMSCatalogFactory.java: ########## @@ -81,6 +86,8 @@ private Catalog createCatalog() { final String configExtWarehouse = MetastoreConf.getVar(configuration, MetastoreConf.ConfVars.WAREHOUSE_EXTERNAL); if (configExtWarehouse != null) { properties.put("external-warehouse", configExtWarehouse); + // HiveCatalog reads this property directly from Configuration, not from properties map + configuration.set("hive.metastore.warehouse.external.dir", configExtWarehouse); Review Comment: You might not have an answer. I'm just curious what makes the drift between Iceberg's HiveCatalog and our HiveCatalog. - https://github.com/apache/hive/blob/7b5433415e42ec92d29636109ea7f522c9354cf4/iceberg/iceberg-catalog/src/main/java/org/apache/iceberg/hive/HiveCatalog.java#L750-L751 - https://github.com/apache/iceberg/blob/91902a87970ff8841e99e6fb3f27f583f7645a6b/hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java#L772 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
