okumin commented on code in PR #6307:
URL: https://github.com/apache/hive/pull/6307#discussion_r2782095864
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java:
##########
@@ -5337,10 +5337,6 @@ protected InputContext(RelDataType inputRowType,
ImmutableMap<String, Integer> c
* and the field trimmer.
*/
public static void warmup() {
- JaninoRelMetadataProvider.DEFAULT.register(HIVE_REL_NODE_CLASSES);
-
HiveDefaultRelMetadataProvider.initializeMetadataProviderClass(HIVE_REL_NODE_CLASSES);
- HiveTezModelRelMetadataProvider.DEFAULT.register(HIVE_REL_NODE_CLASSES);
-
HiveMaterializationRelMetadataProvider.DEFAULT.register(HIVE_REL_NODE_CLASSES);
Review Comment:
Please remove the unused import
https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=6307&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true
##########
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveDefaultRelMetadataProvider.java:
##########
@@ -109,13 +106,6 @@ private RelMetadataProvider init(HiveConf hiveConf,
List<Class<? extends RelNode
HiveRelMdTableReferences.SOURCE,
HiveRelMdAggregatedColumns.SOURCE,
JaninoRelMetadataProvider.DEFAULT)));
-
- if (nodeClasses != null) {
- // If classes were passed, pre-register them
- metadataProvider.register(nodeClasses);
- }
Review Comment:
Double-checked
https://github.com/apache/calcite/blob/calcite-1.33.0/core/src/main/java/org/apache/calcite/rel/metadata/JaninoRelMetadataProvider.java#L195-L200
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
