thomasrebele commented on code in PR #31: URL: https://github.com/apache/hive-site/pull/31#discussion_r2837615095
########## content/docs/latest/aboutthiswiki_27820116.md: ########## @@ -1,13 +1,14 @@ --- + title: "Apache Hive : AboutThisWiki" date: 2024-12-12 ---- Review Comment: I think forcing a certain style would be good, as long as it's easy to enforce. I had a try at implementing the `YamlFrontMatter`, and it works, see https://github.com/apache/hive-site/pull/98. I thought about changing some options of the formatter, to gradually introduce the changes, e.g., [`FORMAT_TABLE_ADJUST_COLUMN_WIDTH`](https://github.com/vsch/flexmark-java/wiki/Tables-Extension) could be set to false. The extra blank lines could be ignored in the first batch as well ([`MAX_BLANK_LINES`](https://github.com/vsch/flexmark-java/wiki/Markdown-Formatter#options)?). However, I could not find a way to set this flexmark option in the pom.xml file. Maybe we better wait until spotless allows [changing the config options for flexmark](https://github.com/diffplug/spotless/issues/2183). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
