kokila-19 opened a new pull request, #6332:
URL: https://github.com/apache/hive/pull/6332
…ArgInFrom
What changes were proposed in this pull request?
In the Dockerfile, Match the case for all keywords (UPPER CASE).
Default value for BUILD_ENV argument. "FROM" determines the base image for
the build and arg BUILD_ENV is used here. If it is empty/invalid , the image
will not be created. So docker lint checks for this issue. To avoid it, a
default value needs to set.
Why are the changes needed?
To remove the warnings thrown during docker build.
```
=> WARN: FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line
19)
=> WARN: FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line
24)
=> WARN: FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line
36)
=> WARN: FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line
47)
=> WARN: InvalidDefaultArgInFrom: Default value for ARG ${BUILD_ENV}
results in empty or invalid base image name (line 47)
```
Does this PR introduce any user-facing change?
No
How was this patch tested?
Create the docker image using build script for both hive and hms image.
./build.sh
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
