ramitg254 commented on code in PR #6314:
URL: https://github.com/apache/hive/pull/6314#discussion_r2839390814
##########
common/src/java/org/apache/hadoop/hive/ql/ErrorMsg.java:
##########
@@ -500,6 +500,7 @@ public enum ErrorMsg {
CATALOG_NOT_EXISTS(10445, "Catalog {0} does not exists:", true),
INVALID_SCHEDULED_QUERY(10446, "Scheduled query {0} does not exist", true),
UNSUPPORTED_TIMESTAMP_PRECISION(10447, "Unsupported value for precision:
{0}", true),
+ TABLE_NOT_EXISTS(10448, "Table does not exist."),
Review Comment:
I think this can be dropped and `INVALID_TABLE` can be used if required
##########
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/LockComponent.java:
##########
@@ -165,12 +172,14 @@ public LockComponent() {
public LockComponent(
LockType type,
LockLevel level,
- java.lang.String dbname)
+ java.lang.String dbname,
Review Comment:
just a suggestion: catName should be passed before dbName as same convention
is followed in most methods
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
