tanishq-chugh commented on code in PR #5535:
URL: https://github.com/apache/hive/pull/5535#discussion_r2870654313
##########
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java:
##########
@@ -5737,11 +5737,11 @@ public static enum ConfVars {
REWRITE_POLICY("hive.rewrite.data.policy", "DEFAULT",
"Defines the rewrite policy, the valid values are those defined in
RewritePolicy enum"),
- HIVE_OTEL_METRICS_FREQUENCY_SECONDS("hive.otel.metrics.frequency.seconds",
"0s",
+ HIVE_OTEL_METRICS_FREQUENCY_SECONDS("hive.otel.metrics.frequency.seconds",
"2s",
new TimeValidator(TimeUnit.SECONDS),
"Frequency at which the OTEL Metrics are refreshed, A value of 0 or
less disable the feature"),
- HIVE_OTEL_COLLECTOR_ENDPOINT("hive.otel.collector.endpoint", "",
+ HIVE_OTEL_COLLECTOR_ENDPOINT("hive.otel.collector.endpoint",
"http://otelcollector:5650";,
Review Comment:
Removed in commit
[1ada154](https://github.com/apache/hive/pull/5535/commits/1ada1543b3e7998e842e52b44605885434c7f254)
##########
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java:
##########
@@ -5737,11 +5737,11 @@ public static enum ConfVars {
REWRITE_POLICY("hive.rewrite.data.policy", "DEFAULT",
"Defines the rewrite policy, the valid values are those defined in
RewritePolicy enum"),
- HIVE_OTEL_METRICS_FREQUENCY_SECONDS("hive.otel.metrics.frequency.seconds",
"0s",
+ HIVE_OTEL_METRICS_FREQUENCY_SECONDS("hive.otel.metrics.frequency.seconds",
"2s",
Review Comment:
Removed in commit
[1ada154](https://github.com/apache/hive/pull/5535/commits/1ada1543b3e7998e842e52b44605885434c7f254)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
