VenuReddy2103 commented on code in PR #6347:
URL: https://github.com/apache/hive/pull/6347#discussion_r2883332823
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java:
##########
@@ -199,11 +199,11 @@ public MetaStoreDirectSql(PersistenceManager pm,
Configuration conf, String sche
this.schema = schema;
this.dbType = PersistenceManagerProvider.getDatabaseProduct();
int batchSize = MetastoreConf.getIntVar(conf,
ConfVars.DIRECT_SQL_PARTITION_BATCH_SIZE);
- this.directSqlInsertPart = new DirectSqlInsertPart(pm, dbType, batchSize);
if (batchSize == DETECT_BATCHING) {
batchSize = dbType.needsInBatching() ? 1000 : NO_BATCHING;
}
this.batchSize = batchSize;
+ this.directSqlInsertPart = new DirectSqlInsertPart(pm, dbType, batchSize);
Review Comment:
This makes oracle, sql server and postgres to limit the batch size to 1000
now. You would probably want to look at DatabaseProduct#getMaxRows() ?
https://github.com/apache/hive/blob/89631dc8c43ee951017fe6ae3ed7c5286f90be8d/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/DatabaseProduct.java#L850
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
