difin commented on code in PR #6325:
URL: https://github.com/apache/hive/pull/6325#discussion_r2891948401
##########
ql/src/java/org/apache/hadoop/hive/ql/plan/DynamicPartitionCtx.java:
##########
@@ -238,8 +243,23 @@ public String getSPPath() {
return this.spPath;
}
+ public List<Function<List<ExprNodeDesc>, ExprNodeDesc>>
getCustomPartitionExpressions() {
+ return customPartitionExpressions == null
+ ? Collections.emptyList()
+ : customPartitionExpressions;
+ }
+
+ public void addCustomPartitionExpressions(List<Function<List<ExprNodeDesc>,
ExprNodeDesc>> customPartitionExpressions) {
+ if
(!org.apache.commons.collections.CollectionUtils.isEmpty(customPartitionExpressions))
{
+ this.hasCustomSortExpr = true;
Review Comment:
The flag name `hasCustomSortExpr` is misleading because it suggests only
sort expressions, but it also covers partition transforms. Should we rename it
to something like `hasCustomPartitionOrSortExpr` to better match its behavior?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
