nareshpr commented on code in PR #6352:
URL: https://github.com/apache/hive/pull/6352#discussion_r2897137154
##########
ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeGenericFuncDesc.java:
##########
@@ -94,7 +94,7 @@ public ExprNodeGenericFuncDesc(ObjectInspector oi, GenericUDF
genericUDF,
ObjectInspectorUtils.getWritableObjectInspector(oi);
assert (genericUDF != null);
this.genericUDF = genericUDF;
- this.children = children;
+ this.children = children == null ? new ArrayList<>() : new
ArrayList<>(children);
Review Comment:
@ayushtkn if we don't explicitly convert it to ArrayList, kryo cannot
determine the actual runtime List object for ExprNodeGenericFuncDesc.children
and uses AbstractMapBasedMultimap$WrappedCollection which is throwing NPE at
deserializer in Tez Task.
Explicit cast ensure kryo knows its ArrayList and won't use
AbstractMapBasedMultimap$WrappedCollection avoiding this NPE.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
