deniskuzZ commented on code in PR #6387:
URL: https://github.com/apache/hive/pull/6387#discussion_r2973520810
##########
itests/test-docker/k8s/hive-metastore/deployment.yaml:
##########
@@ -40,7 +40,7 @@ spec:
- |
apt-get update
apt-get install -y --no-install-recommends ca-certificates wget
- wget
https://repo1.maven.org/maven2/software/amazon/awssdk/bundle/2.26.19/bundle-2.26.19.jar
-P /tmp/ext-jars
+ wget
https://repo1.maven.org/maven2/software/amazon/awssdk/bundle/2.41.3/bundle-2.41.3.jar
-P /tmp/ext-jars
Review Comment:
AWS SDK v2 bundle does NOT include `aws-secretsmanager-caching-java`, or am
i missing something here?
do you mean exclude in root pom DM?
```
<dependency>
<groupId>com.amazonaws.secretsmanager</groupId>
<artifactId>aws-secretsmanager-caching-java</artifactId>
<exclusions>
<exclusion>
<groupId>com.amazonaws</groupId>
<artifactId>aws-java-sdk-secretsmanager</artifactId>
</exclusion>
</exclusions>
</dependency>
````
maybe better implement a small in-memory cache around the v2 client
````
SecretsManagerClient client = SecretsManagerClient.create();
LoadingCache<String, String> cache =
Caffeine.newBuilder()
.expireAfterWrite(Duration.ofMinutes(5))
.build(secretId -> {
GetSecretValueResponse resp =
client.getSecretValue(r -> r.secretId(secretId));
return resp.secretString();
});
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
