ramitg254 commented on code in PR #6337:
URL: https://github.com/apache/hive/pull/6337#discussion_r2973662214
##########
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/create/like/CreateTableLikeOperation.java:
##########
@@ -100,7 +100,7 @@ private Table createViewLikeTable(Table oldTable) throws
HiveException {
setUserSpecifiedLocation(table);
table.setFields(oldTable.getCols());
- table.setPartCols(oldTable.getPartCols());
+ table.setPartCols(oldTable.getNativePartCols());
Review Comment:
kept the old signature
##########
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/column/show/ShowColumnsOperation.java:
##########
@@ -66,10 +66,7 @@ private List<FieldSchema> getColumnsByPattern() throws
HiveException {
private List<FieldSchema> getCols() throws HiveException {
Table table = context.getDb().getTable(desc.getTableName());
- List<FieldSchema> allColumns = new ArrayList<>();
- allColumns.addAll(table.getCols());
- allColumns.addAll(table.getPartCols());
- return allColumns;
+ return new ArrayList<>(table.getAllCols());
Review Comment:
It was already cloning it so I just replaced
```
List<FieldSchema> allColumns = new ArrayList<>();
allColumns.addAll(table.getCols());
allColumns.addAll(table.getPartCols());
```
with
`new ArrayList<>(table.getAllCols());`
##########
hcatalog/core/src/test/java/org/apache/hive/hcatalog/mapreduce/TestHCatMultiOutputFormat.java:
##########
@@ -374,7 +374,7 @@ private List<String> getTableData(String table, String
database) throws Exceptio
Hive hive = Hive.get(conf);
org.apache.hadoop.hive.ql.metadata.Table tbl = hive.getTable(database,
table);
FetchWork work;
- if (!tbl.getPartCols().isEmpty()) {
+ if (!tbl.getSupportedPartCols().isEmpty()) {
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
