shubhluck commented on PR #6382: URL: https://github.com/apache/hive/pull/6382#issuecomment-4115485277
@soumyakanti3578 Thanks for the review! Addressed all feedback: Added getColumnStatsOrEmpty() - returns empty list instead of null. Now used in all 4 locations (3 original + SemanticAnalyzer.getMaterializedTableStats()). Fixed updateStats() behavior - when useColStats=true but stats are empty, we now fall back to ratio-based calculation instead of setting empty stats. Added LOG.warn for visibility. Investigated other callers - all safe: SortedDynPartitionOptimizer, StatsRulesProcFactory (UDTF), GenericUDAFBloomFilter, GroupingSetOptimizer, and ConvertJoinMapJoin already have null handling. Added unit tests for getColumnStatsOrEmpty() and the updated behavior in updateStats()/getColStatisticsUpdatingTableAlias(). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
