zhangbutao commented on code in PR #6267: URL: https://github.com/apache/hive/pull/6267#discussion_r2979582881
########## standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/CatalogUtil.java: ########## @@ -0,0 +1,41 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.hive.metastore; + +import org.apache.commons.lang3.EnumUtils; + +import java.util.EnumSet; +import java.util.Set; + +public class CatalogUtil { + public enum CatalogType { + NATIVE, Review Comment: Good catch. I think I’ve been mixing up the use of connector type and catalog type. However, it seems that different open-source components define connectors and catalogs differently. For example, Trino uses the term connector to describe multi-source federated queries, as seen in https://trino.io/docs/current/connector.html. On the other hand, StarRocks and Apache Doris use the catalog to describe federated query capabilities. In Apache Gravitino, the usage of the catalogs and connector has a different positioning. In Gravitino, catalogs refer to the various data sources that the Gravitino server can uniformly manage, as shown in https://github.com/apache/gravitino/tree/main/catalogs. Meanwhile, connectors refer to the various engines that implement their own read/write plugins to read and write multiple types of data through Gravitino, such as in https://github.com/apache/gravitino/tree/main/spark-connector. So, in Hive, how should we define the use of connector and catalog? :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
