konstantinb commented on code in PR #6359:
URL: https://github.com/apache/hive/pull/6359#discussion_r2988776330
##########
ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUtils.java:
##########
@@ -1578,7 +1578,7 @@ public static ColStatistics
getColStatisticsFromExpression(HiveConf conf, Statis
csList.add(cs);
}
if (csList.size() == engfd.getChildren().size()) {
- Optional<ColStatistics> res = se.estimate(csList);
+ Optional<ColStatistics> res = se.estimate(csList, numRows);
Review Comment:
The very first iteration had just his:
https://github.com/apache/hive/pull/6359/changes/d90457f2c80ac2be43f1efe6bd1442ba9c508f39
This felt a bit "too high level" to me, but thinking further, it indeed
makes more sense to enforce here rather than on the estimator level, thank you
@zabetak
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
