deniskuzZ commented on code in PR #6379:
URL: https://github.com/apache/hive/pull/6379#discussion_r3001119493
##########
llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapCacheMetadataSerializer.java:
##########
@@ -168,8 +169,16 @@ private static DiskRangeList
decodeRanges(List<LlapDaemonProtocolProtos.CacheEnt
}
private static CacheTag decodeCacheTag(LlapDaemonProtocolProtos.CacheTag ct)
{
- return ct.getPartitionDescCount() == 0 ? CacheTag.build(ct.getTableName())
: CacheTag
- .build(ct.getTableName(), ct.getPartitionDescList());
+ String tableName = ct.getTableName();
+ int firstSeparator = tableName.indexOf('.');
Review Comment:
can we refactor
````
String tableName = ct.getTableName();
String[] parts = tableName.split("\\.");
if (parts.length == 2) {
// db.table without catalog, prepend default catalog
tableName = Warehouse.DEFAULT_CATALOG_NAME + "." + tableName;
}
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
