deniskuzZ commented on code in PR #6379:
URL: https://github.com/apache/hive/pull/6379#discussion_r3023138011
##########
ql/src/java/org/apache/hadoop/hive/llap/ProactiveEviction.java:
##########
@@ -233,19 +258,26 @@ public
List<LlapDaemonProtocolProtos.EvictEntityRequestProto> toProtoRequests()
* @return true if cacheTag matches and the related buffer is eligible for
proactive eviction, false otherwise.
*/
public boolean isTagMatch(CacheTag cacheTag) {
+ String catalog = getSingleCatalogName();
Review Comment:
fromProtoRequest() could just store catalogName and dbName as direct fields
instead of stuffing them into the nested map.
Then isTagMatch() wouldn't need the `getSingle*` methods at all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
