ayushtkn commented on code in PR #6385:
URL: https://github.com/apache/hive/pull/6385#discussion_r3026495118
##########
pom.xml:
##########
@@ -92,7 +92,7 @@
<test.excludes.additional/>
<!-- Plugin and Plugin Dependency Versions -->
<ant.contrib.version>1.0b3</ant.contrib.version>
- <maven.test.jvm.args>-Xmx2048m -DJETTY_AVAILABLE_PROCESSORS=4
-Duser.country=US -Dio.netty.tryReflectionSetAccessible=true
-Djava.locale.providers=COMPAT,CLDR --add-opens java.base/java.net=ALL-UNNAMED
--add-opens java.base/java.util=ALL-UNNAMED --add-opens
java.base/java.lang=ALL-UNNAMED --add-opens java.base/java.nio=ALL-UNNAMED
--add-opens java.base/java.util.concurrent=ALL-UNNAMED --add-opens
java.base/java.util.concurrent.atomic=ALL-UNNAMED --add-opens
java.base/java.util.regex=ALL-UNNAMED --add-opens
java.base/java.lang.reflect=ALL-UNNAMED --add-opens
java.sql/java.sql=ALL-UNNAMED --add-opens java.base/java.io=ALL-UNNAMED
--add-opens java.base/java.text=ALL-UNNAMED</maven.test.jvm.args>
+ <maven.test.jvm.args>-Xmx2048m -DJETTY_AVAILABLE_PROCESSORS=4
-Duser.country=US -Dio.netty.tryReflectionSetAccessible=true
-Djava.locale.providers=COMPAT,CLDR --add-opens java.base/java.net=ALL-UNNAMED
--add-opens java.base/java.util=ALL-UNNAMED --add-opens
java.base/java.lang=ALL-UNNAMED --add-opens java.base/java.nio=ALL-UNNAMED
--add-opens java.base/java.util.concurrent=ALL-UNNAMED --add-opens
java.base/java.util.concurrent.locks=ALL-UNNAMED --add-opens
java.base/java.util.concurrent.atomic=ALL-UNNAMED --add-opens
java.base/java.util.regex=ALL-UNNAMED --add-opens
java.base/java.lang.reflect=ALL-UNNAMED --add-opens
java.sql/java.sql=ALL-UNNAMED --add-opens java.base/java.io=ALL-UNNAMED
--add-opens java.base/java.text=ALL-UNNAMED</maven.test.jvm.args>
Review Comment:
this is done only in maven test jvm args, this would kick in only for test
execution not for prod when you actually deploy.
We need to update it at multiple places, where this can kick in.
cc. @tanishq-chugh
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
