deniskuzZ commented on code in PR #6390: URL: https://github.com/apache/hive/pull/6390#discussion_r3027767357
########## packaging/src/docker/stop-hive.sh: ########## @@ -0,0 +1,46 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +#!/usr/bin/env bash +set -e + +SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)" +cd "$SCRIPT_DIR" + +PROFILE="" +CLEANUP_FLAG="" + +for arg in "$@"; do + case "$arg" in + --llap) + PROFILE="--profile llap" Review Comment: i think that is redundant in case of stop. we should auto-detect if llap is enabled ```` CLEANUP_FLAG="" # Parse arguments for arg in "$@"; do case "$arg" in --cleanup) CLEANUP_FLAG="--volumes" ;; *) echo "Unknown option: $arg" exit 1 ;; esac done # Check if llapdaemon exists/running LLAP_EXISTS=$(docker compose ps -q llapdaemon) PROFILE="" if [[ -n "$LLAP_EXISTS" ]]; then PROFILE="--profile llap" fi # Message if [[ -n "$CLEANUP_FLAG" ]]; then echo "Stopping Hive cluster and removing compose volumes" else echo "Stopping Hive cluster (volumes preserved; use --cleanup to remove them)" fi # Stop docker compose docker compose $PROFILE down $CLEANUP_FLAG ```` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
