abstractdog commented on code in PR #6414:
URL: https://github.com/apache/hive/pull/6414#discussion_r3051754575
##########
packaging/src/docker/stop-hive.sh:
##########
@@ -21,19 +21,25 @@ cd "$SCRIPT_DIR"
PROFILE="--profile llap" # delete all containers regardless of profile
CLEANUP_FLAG=""
+COMPOSE_FILES="docker-compose.yml"
for arg in "$@"; do
case "$arg" in
--cleanup)
CLEANUP_FLAG="--volumes"
;;
+ --ozone)
Review Comment:
I feel that we don't need `--ozone` flag for stop script, simply delete
ozone containers all the time
while working on the LLAP image, we made it work by `stop-hive.sh` (no
`--llap`) regardless of the execution mode, so similarly, `stop-hive.sh` should
delete all the containers regardless of the storage, as in the context of
dockerized hive testing, it makes no sense to keep the storage containers
running beyond the hive containers: we should not let the user to achieve this
by accidentally calling `stop-hive.sh` without `--ozone`
later we will have more traits to be added to this cluster (even
concurrently: like `start-hive.sh --ozone --another_storage
--some_amazing_thirdparty_catalog`, I wish the user can simply stop the cluster
without recalling all the arguments used upon creation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
