ayushtkn commented on code in PR #6408: URL: https://github.com/apache/hive/pull/6408#discussion_r3053054764
########## ql/src/java/org/apache/hadoop/hive/ql/io/parquet/vector/VectorizedParquetRecordReader.java: ########## Review Comment: For the Map there is test but the output is wrong, it is testing for `null` but the output is having 0, https://github.com/apache/hive/blame/13f3208c01fec2d20108302efc3fd033d1d76a19/ql/src/test/results/clientpositive/llap/parquet_map_null_vectorization.q.out#L153-L158 It should have been ``` +-----+---------------+ | id | intmap | +-----+---------------+ | 1 | {1:null,2:3} | | 2 | NULL | +-----+---------------+ ``` The inserts were ``` insert into parquet_map_type_int SELECT 1, MAP(1, null, 2, 3) insert into parquet_map_type_int (id) VALUES (2) ``` Let me know if you are ok chasing this separately -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
