dengzhhu653 commented on code in PR #6350:
URL: https://github.com/apache/hive/pull/6350#discussion_r3055534449
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java:
##########
@@ -4289,6 +4282,37 @@ private List<FieldSchema>
get_fields_with_environment_context_core(String db, St
return ret;
}
+ private Table getTableForGetFields(String[] parsedDbName, String
baseTableName)
Review Comment:
nit: it looks a bit redundant for me to create a new method for getting the
table, if we want to transform the NoSuchObjectException to
UnknownTableException, we can handle it in the upper caller
```
catch(Exception e) {
ex = e;
throw handleException(e).convertIfInstance(NoSuchObjectException.class,
UnknownTableException.class).defaultMetaException();
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
