ayushtkn commented on code in PR #6411:
URL: https://github.com/apache/hive/pull/6411#discussion_r3058818029
##########
common/src/scripts/saveVersion.sh:
##########
@@ -36,7 +36,10 @@ if [ "$revision" = "" ]; then
revision=`git log -1 --pretty=format:"%H"`
hostname=`hostname`
branch=`git branch | sed -n -e 's/^* //p'`
- url="git://${hostname}${cwd}"
+ url=$(git remote get-url origin 2>/dev/null)
+ if [ -z "$url" ]; then
+ url="Unknown"
+ fi
Review Comment:
I am not sure if it is very good way to do it. It looks as good as
hardcoding the github repo url.
@zabetak do you have any opinion around this, or how other projects handle it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
