deniskuzZ commented on PR #6413: URL: https://github.com/apache/hive/pull/6413#issuecomment-4221983612
> I am fine with that earlier approach as well but recently I saw this one: https://issues.apache.org/jira/browse/HIVE-29525 so I thought we should have unified getPartCols() and getCols() which gives similar results as native hive tables as first step towards solving this after that those plan logics can be taken care of later on when that ticket will be addressed. So I was first focussing on making getPartCols() unified for iceberg tables as well. > > please share your thoughts on this idea I also tried unified `getPartCols()`, but that ended up requiring column deduplication or adding `supportNonNativePart` in several places. So `effectivePartCol` was more of a cleaner workaround. That said, you’re right—we might be missing some optimizations with the new method. If you’re already looking into it, maybe try getting everything working with a single `getPartCols()` first. That way you can identify all the spots that need adjustments (diff optimizations), and then switch back to the `effectivePartCol` API and drop those interim patches. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
