tanishq-chugh commented on code in PR #6366: URL: https://github.com/apache/hive/pull/6366#discussion_r3077492346
########## ql/src/test/queries/clientpositive/cast_decimal_vectorized.q: ########## @@ -0,0 +1,9 @@ +CREATE TABLE test_stats0 (e decimal(38,10)) stored as orc; +insert into test_stats0 (e) values (0.0); + +set hive.vectorized.execution.enabled=false; +select count(*) from test_stats0 where CAST(e as DECIMAL(15,1)) BETWEEN 100.0 AND 1000.0; + + +set hive.vectorized.execution.enabled=true; +select count(*) from test_stats0 where CAST(e as DECIMAL(15,1)) BETWEEN 100.0 AND 1000.0; Review Comment: Definitely, it would be better to have a sanity check with a different precision as well. Added the same in commit - [78bcca6](https://github.com/apache/hive/pull/6366/commits/78bcca6c723365672520d197f3f34723dcf04e19) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
