ashniku commented on code in PR #6412:
URL: https://github.com/apache/hive/pull/6412#discussion_r3111921951
##########
itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcDriver2.java:
##########
@@ -2661,7 +2699,8 @@ public void testQueryTimeout() throws Exception {
+ " t2 on t1.under_col = t2.under_col");
fail("Expecting SQLTimeoutException");
} catch (SQLTimeoutException e) {
- assertNotNull(e);
+ assertTimeoutMessageShowsOneSecond(
Review Comment:
I have commited new one.The new test testURLWithHiveQueryTimeoutSeconds is
explicitly a 1 second case:
URL — it opens the connection with
getConnection(testDbName, "hive.query.timeout.seconds=1")
so the effective limit is 1 second.
Assertion — it calls assertTimeoutMessageShowsOneSecond, which requires the
message to start with
Query timed out after 1 seconds
(the same constant as testQueryTimeout /
testQueryTimeoutMessageUsesHiveConf).
So it’s aligned with the other 1s timeout tests, just with the limit coming
from the JDBC URL query instead of setQueryTimeout(1) or SET
hive.query.timeout.seconds=1s.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
