tanishq-chugh commented on code in PR #6443:
URL: https://github.com/apache/hive/pull/6443#discussion_r3223937507
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/ColumnStatsSemanticAnalyzer.java:
##########
@@ -257,28 +255,27 @@ private String genRewrittenQuery(List<String> colNames,
List<String> colTypes, H
protected static String genRewrittenQuery(Table tbl,
HiveConf conf, List<TransformSpec> partTransformSpec, Map<String,
String> partSpec,
boolean isPartitionStats) {
- List<String> colNames = getColumnNamesSupportingStats(tbl);
- List<String> colTypes = ColumnStatsSemanticAnalyzer.getColumnTypes(tbl,
colNames);
return ColumnStatsSemanticAnalyzer.genRewrittenQuery(
- tbl, colNames, colTypes, conf, partTransformSpec, -1, partSpec,
isPartitionStats, true);
+ tbl, getStatsEligibleFieldSchemas(tbl).getSchemas(), conf,
partTransformSpec, -1, partSpec, isPartitionStats, true);
}
- private static String genRewrittenQuery(Table tbl, List<String> colNames,
List<String> colTypes,
+ private static String genRewrittenQuery(Table tbl, List<FieldSchema>
columnSchemas,
Review Comment:
Nice catch, have made this change in commit:
[c030988](https://github.com/apache/hive/pull/6443/commits/c030988b39fdef59d0bc2bbe92a4a0215c33e9a2)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
