deniskuzZ commented on code in PR #6341:
URL: https://github.com/apache/hive/pull/6341#discussion_r3246767327
##########
ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java:
##########
@@ -1948,7 +1948,11 @@ private static boolean isDirUsable(Path child, long
visibilityTxnId, List<Path>
}
public static boolean isTablePropertyTransactional(Properties props) {
- return isTablePropertyTransactional(Maps.fromProperties(props));
+ String resultStr = (String)
props.get(hive_metastoreConstants.TABLE_IS_TRANSACTIONAL);
Review Comment:
FYI:
instead code duplication we could have used signature with
`BinaryOperator<String> props` and then
getParameters()::getOrDefault
properties()::getOrDefault
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
