Aggarwal-Raghav commented on code in PR #6489:
URL: https://github.com/apache/hive/pull/6489#discussion_r3249233437
##########
ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java:
##########
@@ -1953,17 +1958,17 @@ private static boolean isDirUsable(Path child, long
visibilityTxnId, List<Path>
}
public static boolean isTablePropertyTransactional(Properties props) {
- String resultStr = (String)
props.get(hive_metastoreConstants.TABLE_IS_TRANSACTIONAL);
- if (resultStr == null) {
- resultStr = (String)
props.get(hive_metastoreConstants.TABLE_IS_TRANSACTIONAL.toUpperCase());
- }
- return Boolean.parseBoolean(resultStr);
+ return isTablePropertyTransactional(props::getProperty);
}
public static boolean isTablePropertyTransactional(Map<String, String>
parameters) {
- String resultStr =
parameters.get(hive_metastoreConstants.TABLE_IS_TRANSACTIONAL);
+ return isTablePropertyTransactional(parameters::get);
+ }
+
+ private static boolean isTablePropertyTransactional(UnaryOperator<String>
prope) {
Review Comment:
nit: `prope` -> `props`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
