InvisibleProgrammer commented on code in PR #6496:
URL: https://github.com/apache/hive/pull/6496#discussion_r3272232169
##########
ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUtils.java:
##########
@@ -300,7 +311,7 @@ private static Statistics collectStatistics(HiveConf conf,
PrunedPartitionList p
if (needColStats && !metaTable) {
colStats = getTableColumnStats(table, neededColumns, colStatsCache,
fetchColStats);
if (estimateStats) {
- estimateStatsForMissingCols(neededColumns, colStats, conf, nr,
schema);
+ colStats = estimateStatsForMissingCols(neededColumns, colStats,
conf, nr, schema);
Review Comment:
I think `List<ColStatistics> colStats = Collections.emptyList();` is still
here. It can lead to future mistakes like trying to use it on the same way as
before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
