thomasrebele commented on code in PR #6487:
URL: https://github.com/apache/hive/pull/6487#discussion_r3274384450
##########
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/txn/compactor/TestCrudCompactorOnTez.java:
##########
@@ -642,15 +167,15 @@ public void
secondCompactionShouldBeRefusedBeforeEnqueueing() throws Exception {
} catch (CommandProcessorException e) {
String errorMessage = ErrorMsg.COMPACTION_REFUSED.format(dbName,
tableName, "",
"Compaction is already scheduled with state='ready for cleaning' and
id=" + resp.getId());
- Assert.assertEquals(errorMessage, e.getCauseMessage());
- Assert.assertEquals(ErrorMsg.COMPACTION_REFUSED.getErrorCode(),
e.getErrorCode());
+ assertEquals(errorMessage, e.getCauseMessage());
+ assertEquals(ErrorMsg.COMPACTION_REFUSED.getErrorCode(),
e.getErrorCode());
Review Comment:
Hm, reducing the workload on the CI is indeed a valid concern. Is it
possible to merge this PR with a rebase, instead of a squash? That way the
import related changes could be move to a separate commit in the same PR. I
wished Github had an interactive rebase feature for merging PRs.
I had a quick search, but couldn't find the discussion. Do you have a link
by chance?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
