dengzhhu653 commented on PR #6450: URL: https://github.com/apache/hive/pull/6450#issuecomment-4504286832
> Hi @dengzhhu653, I started by looking at the overall direction of this PR and some of the test cases, and left a few comments. > > My understanding is that this PR is a refactoring intended to reduce the complexity of `ObjectStore`. Overall, the direction looks reasonable to me. For example, separating transaction handling into `TransactionHandler` seems helpful for simplifying the logic in the sub-stores > > That said, it would be helpful to have a related JIRA, if one exists, so one could better understand the motivation and proposed methods of this PR. I am also curious whether there has already been any discussion about refactoring `ObjectStore`. Yes, we have an old jira for this, https://issues.apache.org/jira/browse/HIVE-14730. I will create a new one with the design document. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
