soumyakanti3578 commented on code in PR #6482:
URL: https://github.com/apache/hive/pull/6482#discussion_r3282686090
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java:
##########
@@ -1036,16 +1041,61 @@ boolean isCBOExecuted() {
}
@Override
- boolean isCBOSupportedLateralView(ASTNode lateralView) {
- // LATERAL VIEW OUTER not supported in CBO
- return lateralView.getToken().getType() !=
HiveParser.TOK_LATERAL_VIEW_OUTER;
+ boolean isCBOSupportedLateralView() {
+ // Both LATERAL VIEW and LATERAL VIEW OUTER are supported in CBO.
+ return !this.conf.getBoolVar(HiveConf.ConfVars.HIVE_CBO_RETPATH_HIVEOP);
Review Comment:
Neither `LATERAL VIEW` nor `LATERAL VIEW OUTER` work with CBO return path.
I'll create a separate ticket for them, as I don't think there's a ticket for
them here: https://issues.apache.org/jira/browse/HIVE-9132
So the current condition in `isCBOSupportedLateralView()` is true for both
types of `LATERAL VIEW` when CBO is enabled (If CBO is not enabled we take a
different path), and it is false only when `HIVE_CBO_RETPATH_HIVEOP` is true
(non default path for CBO). So I think the condition correctly reflects the
current state.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
