difin commented on code in PR #6449:
URL: https://github.com/apache/hive/pull/6449#discussion_r3326038086
##########
iceberg/iceberg-handler/src/test/queries/positive/iceberg_rest_catalog_gravitino.q:
##########
@@ -74,6 +72,54 @@ VALUES ('fn1','ln1', 1, 10), ('fn2','ln2', 2, 20),
('fn3','ln3', 3, 30);
describe formatted ice_orc2;
select * from ice_orc2;
+---------------------------------------------------------------------------------------------------------------------
+--! Iceberg Native View tests
+---------------------------------------------------------------------------------------------------------------------
+
+-- Enable once CBO supports Iceberg native views on partitioned tables
+set hive.cbo.enable=false;
Review Comment:
I removed turning the CBO off and instead added this to `MetastoreUtil`
which sets empty partition keys in REST Catalog client that matches current HMS
behavior for Iceberg tables:
```
// TODO: Revert after HIVE-29633 is fixed
// result.setPartitionKeys(getPartitionKeys(table,
table.spec().specId()));
result.setPartitionKeys(Lists.newArrayList());
```
It makes Iceberg logical views work with partitioned base tables without
turning off CBO.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
