konstantinb commented on PR #6505: URL: https://github.com/apache/hive/pull/6505#issuecomment-4580443902
@zabetak I believe that this PR is a much cleaner alternative to https://github.com/apache/hive/pull/6418 While changing more source files, it impacts much fewer test output results and provides clean separation between "unknown" and "verified 0" NDV values. It also naturally provides a fix for extractNDVGroupingColumns() reported as [HIVE-29556](https://issues.apache.org/jira/browse/HIVE-29556) On top of that, it simplifies the fixes required for PessimisticStatCombiner. The original PR https://github.com/apache/hive/pull/6359 would become much smaller if this is accepted. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
