abstractdog commented on code in PR #6447:
URL: https://github.com/apache/hive/pull/6447#discussion_r3332931272
##########
ql/src/java/org/apache/hadoop/hive/ql/ddl/function/drop/DropFunctionAnalyzer.java:
##########
@@ -41,19 +44,33 @@ public DropFunctionAnalyzer(QueryState queryState) throws
SemanticException {
super(queryState);
}
+ public DropFunctionAnalyzer(QueryState queryState, Hive db) throws
SemanticException {
+ super(queryState, db);
+ }
+
+ protected FunctionInfo getFunctionInfo(String functionName) throws
SemanticException {
Review Comment:
fixed in
https://github.com/apache/hive/pull/6447/changes/fbf0608e53c7325cc35aa8d0a70bcd53f6708153
I didn't like mocked static for the first sight, but given it's test-only
code that makes the production code unaffected, it's okay
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
