abstractdog commented on code in PR #6456:
URL: https://github.com/apache/hive/pull/6456#discussion_r3348290788
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/CommonMergeJoinOperator.java:
##########
@@ -222,6 +240,21 @@ private Set<Integer> getFetchInputAtCloseList() {
return retval;
}
+ private void initSkewJoinNames(int maxAlias) {
+ joinSkewKeyColumns = new String[maxAlias];
+ joinSkewTableAliases = new String[maxAlias];
+
+ String[] descKeyNames = conf.getSkewJoinKeyNames();
+ String[] descTableAliases = conf.getSkewJoinTableAliases();
+
+ for (int pos = 0; pos < maxAlias; pos++) {
+ joinSkewKeyColumns[pos] = (descKeyNames != null && pos <
descKeyNames.length
Review Comment:
`descKeyNames != null` -> `descKeyNames != null` we don't use extra
spacing
can you take care of the same in other places too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
