saihemanth-cloudera commented on code in PR #6499:
URL: https://github.com/apache/hive/pull/6499#discussion_r3351346360
##########
standalone-metastore/metastore-client/src/main/java/org/apache/hadoop/hive/metastore/client/builder/HiveMetaStoreClientBuilder.java:
##########
@@ -32,28 +34,39 @@
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
+import java.lang.reflect.Constructor;
import java.util.Map;
import java.util.Objects;
+import java.util.concurrent.ConcurrentHashMap;
import java.util.function.Function;
public class HiveMetaStoreClientBuilder {
private static final Logger LOG =
LoggerFactory.getLogger(HiveMetaStoreClientBuilder.class);
+ private static final Map<Class<? extends IMetaStoreClient>,
MetaStoreClientFactory>
+ CLIENT_FACTORIES = new ConcurrentHashMap<>();
private final Configuration conf;
private IMetaStoreClient client;
- public HiveMetaStoreClientBuilder(Configuration conf) {
Review Comment:
This will be breaking changes for the HMS clients using this builder class
right?
In the case, Can we keep this constructor and pass a default value for the
argument 'allowEmbedded' in the new constructor?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
