magnuma3 commented on code in PR #6518:
URL: https://github.com/apache/hive/pull/6518#discussion_r3352671435
##########
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java:
##########
@@ -3865,6 +3865,12 @@ public static enum ConfVars {
+ " for HiveServer2 WebUI."),
HIVE_SERVER2_WEBUI_SSL_KEYMANAGERFACTORY_ALGORITHM("hive.server2.webui.keymanagerfactory.algorithm",
"","SSL certificate key manager factory algorithm for HiveServer2
WebUI."),
+
HIVE_SERVER2_WEBUI_USE_CUSTOM_AUTH_FILTER("hive.server2.webui.use.custom.auth.filter",
false,
+ "If true, the HiveServer2 WebUI will be secured with custom auth
filter"),
Review Comment:
Thanks for the review @saihemanth-cloudera!
I initially followed the pattern of the existing
hive.server2.webui.use.spnego and hive.server2.webui.use.pam configs.
I noticed that hive.server2.webui.auth.method was introduced more recently
in HIVE-28457 (4.1.0) but currently only supports NONE and LDAP, so the WebUI
auth configuration is a bit split between the two styles right now.
Is the long-term plan to eventually consolidate use.spnego and use.pam into
hive.server2.webui.auth.method as well? That context would help me align this
PR with the intended direction.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
