InvisibleProgrammer commented on code in PR #6449:
URL: https://github.com/apache/hive/pull/6449#discussion_r3380457466
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/BaseHiveIcebergMetaHook.java:
##########
@@ -204,6 +222,18 @@ public void preCreateTable(CreateTableRequest request) {
setSortOrder(hmsTable, schema, tableProperties);
}
+ private void preCreateNativeIcebergLogicalView(CreateTableRequest request) {
+
+ org.apache.hadoop.hive.metastore.api.Table hmsTable = request.getTable();
Review Comment:
Because of the hook based architecture of the Hive metadata handling, I
interpret BaseHiveIcebergMetaHook as one of the entry points for the Iceberg
code. To me, it is a clear module boundary.
Even if I disagree checking the existence only on a lower level of the code
execution I can live with it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
