tanishq-chugh commented on code in PR #6528:
URL: https://github.com/apache/hive/pull/6528#discussion_r3387501824
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/ZookeeperExternalSessionsRegistryClient.java:
##########
@@ -117,18 +161,33 @@ public void returnSession(String appId) {
throw new IllegalStateException("Not initialized");
}
if (!taken.remove(appId)) {
- return; // Session has been removed from ZK.
+ return; // Session has already been removed from ZK.
}
+
+ try {
+ client.delete().guaranteed().forPath(claimsPath + "/" + appId);
+ } catch (KeeperException.NoNodeException e) {
+ // If the claim Node has already been deleted, we can ignore it.
Review Comment:
Addressed this in commit -
[7f6b08f](https://github.com/apache/hive/pull/6528/commits/7f6b08f77e9da97da9da4fefa0115f40588d969f)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
