deniskuzZ commented on code in PR #6413:
URL: https://github.com/apache/hive/pull/6413#discussion_r3441291752
##########
ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java:
##########
@@ -728,8 +750,50 @@ private boolean isField(String col) {
return false;
}
+ private void ensureColumnsIndexed() {
Review Comment:
@ramitg254, Iceberg does similar thing, please take a look
https://github.com/apache/iceberg/blob/main/api/src/main/java/org/apache/iceberg/Schema.java#L215-L234
````
private Map<Integer, NestedField> lazyIdToField() {
if (idToField == null) {
this.idToField = TypeUtil.indexById(struct);
}
return idToField;
}
private Map<String, Integer> lazyNameToId() {
if (nameToId == null) {
this.nameToId = ImmutableMap.copyOf(TypeUtil.indexByName(struct));
}
return nameToId;
}
public NestedField findField(String name) {
Preconditions.checkArgument(!name.isEmpty(), "Invalid column name:
(empty)");
Integer id = lazyNameToId().get(name);
if (id != null) {
return lazyIdToField().get(id);
}
return null;
}
````
maybe use similar approach: i.e. lazyNameToField + indexFields() ?
````
TColumn column = lazyNameToField.get(colName.toLowerCase());
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
