abstractdog commented on code in PR #6547:
URL: https://github.com/apache/hive/pull/6547#discussion_r3441778020
##########
itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java:
##########
@@ -1020,7 +1020,19 @@ public QTestProcessExecResult checkCliDriverResults()
throws Exception {
qTestResultProcessor.overwriteResults(f.getPath(), outFileName);
return QTestProcessExecResult.createWithoutOutput(0);
} else {
- return qTestResultProcessor.executeDiffCommand(f.getPath(), outFileName,
false);
+ // Apply the same masking pipeline to a temporary copy of the reference
file so that
+ // non-deterministic values are normalized on both sides.
+ // This preserves backward compatibility with existing .q.out files that
were written
+ // before the masking rules were introduced.
Review Comment:
I don't think we need backward compatibility: if the masking rules change,
all the q.outs should change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
